Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test pr 735 #738

Closed
wants to merge 6 commits into from
Closed

Test pr 735 #738

wants to merge 6 commits into from

Conversation

sfc-gh-dheyman
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner December 20, 2023 08:14
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (65f8670) 88.75% compared to head (7c9ab06) 88.79%.
Report is 1 commits behind head on master.

Files Patch % Lines
lib/file_transfer_agent/file_transfer_agent.js 85.71% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
+ Coverage   88.75%   88.79%   +0.04%     
==========================================
  Files          61       61              
  Lines        5689     5702      +13     
==========================================
+ Hits         5049     5063      +14     
+ Misses        640      639       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-dheyman @GabrielLomba